objects as parameter?

Atm I cleaning some code I have. It loops through an array, reads the properties and then build some plugins. A part of this is sending the object(?) name to an action so that action can read the properties. for instance:

for(set(i,0), i LT panorama.pano.count, inc(i), createtext(get(i)));

<action name="createtext">
    addplugin(text_%1);
    copy(plugin[text_%1].html, panorama.pano[%1].title);
</action>

you can imagine alot of panorama.pano[%1].someattribute happens, and later even a second depth is added panorama.pano[%1].variant[%2].title

I was wondering if there was a trick in wich I could just throw the object itself (instead of the name/index) in the action.

createtext(panorama.pano[get(i)]);

I then could do for instance

copy(plugin[someplugin].html, %1.title);

perhaps alsoo not so clean, but im trying to reduce the code. Perhaps better would be creating an object name;

set(object, %1);
copy(plugin[someplugin].html, object.title);

or

copy(object, panorama.pano[get(i)].variant[get(j)]);
copy(plugin[someplugin].html, object.title);

Just throwing some ideas...

Hi What do you mean with:

Zitat

note - the action parameters will be passed just via 'copy and paste' to the %N placeholders in the actions,
so when using there - get(i) - can be problematic when the 'i' variable will be changed during processing,

i could be 0 to any positive number but its assigned to the first parameter, being %1. So even if i is 0, it wouldnt affect %0 since Im not reassining %0, only %1. I can't even imaigine how I would set the %0 from within the action call creatext();

About the other thing, my versioning was wrong, the latest version already supports this :)

Although I have issues with loadstyle now. Normally I could create a style, put some default properties on it, and then in an action still overwrite it if conditions met. But with the loadstyle of the latest version, it seems to always apply the ones in loadstyle() and doesnt get overwritten by setters later on.

Well, I updated krpano to the latest version, and first thing I noticed was that some stuff didnt work anymore. I checked al the code, and the problem lies in the fact that the style applied using loadstyle couldnt be overwritten.

ex (typed it from head, so could have some typos)

<images>
	<image name="image1" width="100" height="100" />
	<image name="image2" width="200" height="100" />
</images>


<style name="image_style" onclick="openPopup(get(name))" url="plugins/textfield.swf" />


<action name="load_images()">
	for(set(i,0), i LT images.image.count, inc(i),
		txtadd(tplugin, 't_image_', get(i));
		addplugin(tplugin);
		add_image(tplugin, get(i));
	);
</action>
<action name="add_image()">
	plugin[%1].loadstyle(image_style);
	
	if(isflash,
		set(plugin[%1].onclick, trace('flash action'));
	);
	
	mul(tmpx, images.image[%2].width, %2);
	copy(plugin[%1].x, tmpx);
</action>

in version of 5 - 10, the onclick set in add_image() is set if isflash == true.

In the latest version this code keeps the style loaded with loadstyle persistent (doesnt allow for overwriting).

concerning the other point:

Zitat

%0 can't be set, this is always the name of the called action,

This is what I said, but you said:

Zitat

note - the action parameters will be passed just via 'copy and paste' to the %N placeholders in the actions,
so when using there - get(i) - can be problematic when the 'i' variable will be changed during processing,

I dont understand how get(i) can be problematic. Its just a number put in %1.

nah like I said, i did it by head, since my real code is a bit more complex...

My real code is:

<action name="add_menu_items">
		set(menuxoffset, 0);
		add(plugin[menu_content_wrapper].y, menu.padding);
		<!-- set menu height -->
		copy(plugin[menu-active-background].height, menu.height);
        <!-- loop through every 1st panorama.location.pano and add them to the stage -->
		for(set(i,0), i LT panorama.location.count, inc(i),
            copy(pname, panorama.location[get(i)].pano[0].name);
            addplugin(get(pname));
            add_menu_item(get(pname));
        );
	</action>


    <style name="menu_style"
           background="true"
           parent="menu_content_wrapper"
           url="%SWFPATH%/plugins/textfield.swf"
           keep="true"
           align="bottomleft"
           children="false"
           zorder="1"
           enabled="true"
           scalechildren="true"
           border="true"
           y="0"
           onhover="show_tooltip(get(html))"
           onover="if(active == false, set(css, data:OverCSS));"
           onout="if(active == false, set(css, data:NormalCSS));"
           active="false"
           css="data:NormalCSS"
           menuopened="false"
     />


    <action name="add_menu_item">
        plugin[%1].loadstyle(menu_style);


		copy(plugin[%1].borderwidth,menu.border);
		copy(plugin[%1].bordercolor, menu.bordercolor);
		copy(plugin[%1].height, menu.languages.language[get($_LANGUAGE)].item_height);
		copy(plugin[%1].width, menu.languages.language[get($_LANGUAGE)].item_width);


		copy(plugin[%1].backgroundcolor, menu.backgroundcolor);
        copy(plugin[%1].scene, panorama.location[%1].pano[0].name);
        copy(plugin[%1].location, panorama.location[%1].name);
		copy(plugin[%1].alpha, menu.alpha);


        trace('menu item location: ', plugin[%1].location);
        <!-- offset menuitems -->
        copy(plugin[%1].x, menuxoffset);
		add(menuxoffset, get(plugin[%1].width));
		add(menuxoffset, menu.padding);


        <!-- Set the title of the menu item according to language -->
		txtadd(plugin[%1].html, '<p>', get(data[get(panorama.location[%1].pano[0].title)].content), '</p>');


		<!-- if menu has subitems, then add create_subitems action, else read the onclick out of menu object -->
		if(panorama.location[%1].pano.count GT 1,
			set(plugin[%1].onclick,
                load_panorama(get(scene),get(location));
				<!--set_menuitem_active();-->
				create_subitems();


			);
            ,
            set(plugin[%1].onclick,
                    load_panorama(get(scene),get(location));
                   <!-- set_menuitem_active();-->
            );
		);
    </action>

In this example I use an if else for the onclick. But in the version of 05-10 this wasnt nessesary. I could put the "else" in the style and overwrite it if the if statement came true. I had several actions with this construct that worked with version 05-10.

I cant recreate the problem either. In my current tour its still broken. I removed all the xml related to generating a bunch of textfields in a for loop. Only left the bare minimum. It doesnt work. If I then copy it to a new blank tour, the exact same code works. Both krpano versions are the same. I'm puzzled, but I'd guess this is is something I have to figure out on my own.

any idea what could prevent a style not to be overwritten? or is it because perhaps so much is going on in the main pano, that the loadstyle is applied to late? (so i add a custom onclick, and then the loadstyle gets triggered, even if the loadstyle is before the onclick?).

ok update!

adding a

plugin[%1].loadstyle(style_subitem);
	delayedcall(0, set(plugin[%1].onhover, showtext('bleh')));

delayedcall fixed the problem. I dunno why, but it does...

Ah well, like I said, the code works perfectly fine in a seperate clean xml. But within my project it needs a delayedcall(0, ) with the property i need to overwrite. Strange, but it works :)