Overload attributes with GET:

Anfänger

Donnerstag, 10. Januar 2019, 18:56

Overload attributes with GET:

Hi,

I've been using GET: a bit and it seems like if you use a GET: in a given attribute, then one cannot overload this attribute.

<hotspot name="myhotspot" type="text" visible="true" distorted="true"
ath="0" atv="0"
html="myhotspot"
/>

<hotspot name="myhotspotcopy" type="text" visible="true" distorted="true"
ath="20" atv="0"
html="get:hotspot[myhotspot].html"
/>



<hotspot name="myhotspotcopy" type="text" visible="true" distorted="true"
ath="90" atv="0"
html="this text should be shown"
/>

The last override should make the myhotspotcopy hotspot move (as ath changes) and the text change (as html changes).
But only the ath gets overloaded.

Actually anywhere I use GET: , afterwards I cannot overload this attributes. Seems likes using GET: blocks any overloading.

Normal? Bug?

Florian

Zum Seitenanfang

Tuur

Erleuchteter

Beiträge: 3 839

Wohnort: Netherlands

Beruf: Krpano custom coding / Virtual Tours / Photography / Musician / Recording engineer

Donnerstag, 10. Januar 2019, 21:57

Hi,

Use like get(hotspot[bla...etc );

get: has other use.

Hope it helps.
Tuur *thumbsup*

https://www.virtualtuur.com
Panimator: https://krpano.com/plugins/userplugins/panimator/#top
ToolBox: https://bit.ly/3TTnd6U
Measure in 360 photos

: https://pame.virtualtuur.com
Moving Hotspots V2: https://krpano.com/plugins/userplugins/movinghotspots/#top
Donations
https://bit.ly/3NnpynC

Zum Seitenanfang

lerayfle

Anfänger

Beiträge: 50

Samstag, 12. Januar 2019, 15:57

Hmm...
- Using get() does not seem to be possible in attributes
- documentation says GET: is meant to be used that way, and Klaus himself uses it in vtourskin.xml, what am I doing wrong?

Zitat

When the value of a xml attribute starts with get: or calc::
In this case the value for the xml attribute will get from an other variable or calculated using an expression

And in the doc about overwrite, it says :

Zitat

All xml elements and attributes in the krpano xml are optionally and can be defined a several times and in any order. When the same element will be defined again two or more times, then the later/following declarations will overwrite the previous one.

Nothing says GET: attributes cannot be overriden.

I can of course use get() in actions, it's a way round I was using a lot, before GET: was introduced. But styles are so nice to use, and a bit more concise than actions (a simple loadstyle instead of multiple set(attribute, value) lines)

Zum Seitenanfang

pur

Schüler

Beiträge: 97

Sonntag, 13. Januar 2019, 22:18

Florian,
Just from top of my head (without testing) seems that's all about timing. Although the source hotspot is written in the xml code above the hotspot with GET: statement it does not mean that the hotspot is already available when loaded for the particular scene.
I do my settings in onloaded="set(html, get(source.html))"
The "cleanest" way is apparently using onloaded"callwhen(source.loaded, set(html, source.html))"

Please correct me if I'm wrong.
Thank you,
Pavel

Zum Seitenanfang

lerayfle

Anfänger

Beiträge: 50

Montag, 14. Januar 2019, 15:38

Yep, I also got to use that onloaded way-round *g*

But anyway, documentation says "the later/following declarations will overwrite the previous one", which in this case is not true

Zum Seitenanfang

$»indexofrefraction« ist offline$ indexofrefraction

Profi

Beiträge: 1 362

Montag, 14. Januar 2019, 18:11

i noticed that behaviour, too
it also happens when using multiple xml files

ie. you want to override your main xml in an included xml
overriding a get: statement does NOT work in this case, too
I just tested it now.

this strikes me as very odd and may be a bug.

zFilter plugin -- zFlare plugin -- zSnapshot plugin

Zum Seitenanfang

klaus.krpano

Administrator

Beiträge: 13 499

Dienstag, 15. Januar 2019, 10:17

Hi,

right, once using get: or calc: it is currently not possible to overwrite that setting again with a normal value...

The reason is that attributes with get:/calc: are getting put to a special list during the xml parsing and evaluated after the main part of the xml parsing is done.

To allow overwriting these attributes again with normal values, it would be necessary to check each time for every other attribute if it is also on that list, and that could be inefficient and slow...

But I will check and measure that in detail and maybe by using a hash-table instead of a list it might be possible to keep the slow-down for supporting this as low as possible...

Best regards,
Klaus

Zum Seitenanfang

klaus.krpano

Administrator

Beiträge: 13 499

Dienstag, 15. Januar 2019, 10:33

Zitat von »klaus.krpano«

But I will check and measure that in detail and maybe by using a hash-table instead of a list it might be possible to keep the slow-down for supporting this as low as possible...

Update: I have checked and updated that now to internal hash-table usage and the performance is okay.
That means in the next version overwriting/redefining xml attributes that used get:/calc: will be possible.