1.21 bug: js(...) stopped working

zbooy · February 8, 2023 at 12:55 PM

Hi,

I have just tried updating my site to v1.21 only to find out that js() calls from xml no longer work.

js( console.log(1) ); does nothing
js( "console.log(1)" ); as well

while jscall( console.log(1) ); works fine

klaus.krpano · February 8, 2023 at 2:40 PM

Hi,

thanks, right!
That will be fixed with the next release.

But generally I would recommend switching to using jscall(). Even with the fix, the js() action will be limited to calling only one Javascript function, where with jscall you can call any arbitrary code.

Best regards,
Klaus

zbooy · February 8, 2023 at 3:04 PM

Hi,

actually I did change some js() calls into jscall() but what about the ones using action arguments, like
js( console.log(get(%1)); );
?

klaus.krpano · February 8, 2023 at 5:06 PM

Either build a string:

Code

jscall(('console.log(' + get(%1) + ')'));

or use krpano.get() to load the value from JS:

Code

jscall( console.log(krpano.get('%1')) );

zbooy · February 8, 2023 at 9:04 PM

Thank you, krpano.get('%1') was the way to go.
Version 1.21 indeed seems to be noticeably faster on a scene with lots of text hotspots.

worinima2128 · February 9, 2023 at 2:06 AM

Quote from klaus.krpano

Hi,
thanks, right!
That will be fixed with the next release.
But generally I would recommend switching to using jscall(). Even with the fix, the js() action will be limited to calling only one Javascript function, where with jscall you can call any arbitrary code.

Best regards,
Klaus

Personally, I prefer to use js not jscall, although they can achieve the same function

klaus.krpano · February 9, 2023 at 11:35 AM

Hi,

there is a new build (2023-02-09) where this is fixed now.

Quote from worinima2128

Personally, I prefer to use js not jscall, although they can achieve the same function

No problem with that, the main difference between js() and jscall() is that js() can only call one Javascript-Function, where in jscall() you can use any kind of Javascript code.

Participate now!