Sie sind nicht angemeldet.

krpano 1.21 (pre-release)

kme

Fortgeschrittener

Beiträge: 310

Wohnort: Belgium

Beruf: Long time coder, product manager and 3D enthousiast

  • Nachricht senden

181

Donnerstag, 23. März 2023, 11:57

Hey San7,

This looks like a scope issue: while doing the tween on hs, the hs is overwritten (copy) with a new value and then that new value is tweened :)

Maybe this could work (not tested):

Quellcode

 
1
2
3
4
5
6
7
8
9
10

	<action name="hid_show_hs" scope="local"  args="stat" > 
		for(set(i, 0), i LT hotspot.count, inc(i),  	
			copy(hs, hotspot[get(i)]);
			if(hs.name == 'infohs', 
				copy(hstotween, hotspot[get(i)]);
				trace(hstotween.name);
				tween(hstotween.alpha, get(stat));
			);
		);
	</action>
Plugins and more on my gumroad page

kme

Fortgeschrittener

Beiträge: 310

Wohnort: Belgium

Beruf: Long time coder, product manager and 3D enthousiast

  • Nachricht senden

182

Donnerstag, 23. März 2023, 12:03

Or even better is this, because then we are absolutely sure we tween the correct hotspot...

Quellcode

 
1
2
3
4
5
6
7
8
9

	<action name="hid_show_hs" scope="local"  args="stat" > 
		for(set(i, 0), i LT hotspot.count, inc(i),  	
			copy(hs, hotspot[get(i)]);
			if(hs.name == 'infohs', 
				trace(hs.name);
				tween(hotspot[get(i)].alpha, get(stat));
			);
		);
	</action>
Plugins and more on my gumroad page

Dieser Beitrag wurde bereits 1 mal editiert, zuletzt von »kme« (23. März 2023, 12:17)

Tuur

Erleuchteter

Beiträge: 3 839

Wohnort: Netherlands

Beruf: Krpano custom coding / Virtual Tours / Photography / Musician / Recording engineer

  • Nachricht senden

183

Donnerstag, 23. März 2023, 12:08

Hi San,

we used to add a for loop helper script to do, for example, tweening for hotspots and layers..in the past..because of this behaviour.
remember HelperAction(get(hotspot[get(i)].name)); ? (or so..)
'callwith' is your friend since some years *whistling*

this works:

Quellcode

 
1
2
3
4
5
6
7
8
9
10
11
12
13
14

		<layer name="test1"  type="text" align="top" x="-30" html="on infohs" onclick="hid_show_hs(1)"/> 
		<layer name="test2"  type="text" align="top" x="30"  html="off infohs" onclick="hid_show_hs(0)"/> 

		<hotspot name="infohs"  type="image" url="gallery.png" /> 
		<hotspot name="hsp_1"  type="image" url="VT.png"  ath="-30"   />

		<action name="hid_show_hs" scope="local" args="stat"> 
		  forall(hotspot,h,
			if(h.name == 'infohs',
				trace(h.name);
				callwith(h, tween(alpha, *stat));
			);
		  );
  		</action>


Hope it helps
Tuur *thumbsup*
https://www.virtualtuur.com
Panimator: https://krpano.com/plugins/userplugins/panimator/#top
ToolBox: https://bit.ly/3TTnd6U
Measure in 360 photos : https://pame.virtualtuur.com
Moving Hotspots V2: https://krpano.com/plugins/userplugins/movinghotspots/#top
Donations
https://bit.ly/3NnpynC

kme

Fortgeschrittener

Beiträge: 310

Wohnort: Belgium

Beruf: Long time coder, product manager and 3D enthousiast

  • Nachricht senden

184

Donnerstag, 23. März 2023, 12:19

I ususally use San7 approach for looping through hotspts, but Tuur, your code looks so much clearner! *thumbup*
Plugins and more on my gumroad page

Tuur

Erleuchteter

Beiträge: 3 839

Wohnort: Netherlands

Beruf: Krpano custom coding / Virtual Tours / Photography / Musician / Recording engineer

  • Nachricht senden

185

Donnerstag, 23. März 2023, 12:25

Zitat

I ususally use San7 approach for looping through hotspts, but Tuur, your code looks so much clearner!


yes but since the beginning of times doing a tween or so like that on a hotspot doesn't work in a for loop.
My code is just the same but the new syntax is used.
The callwith 'trick' worked already since it was available.

We used to do, because of this, for example:

Quellcode

 
1
2
3
4
5
6
7
8
9

for(set(i,0),i LT hotspot.count, inc(i),
		if(hotspot[get(i)].tag == 'labrador',
			Helper(get(hotspot[get(i)].name));
		);
);		
		
<action name="Helper">
		tween(hotspot[%1].volume, 9);
</action>


Tuur *thumbsup*
https://www.virtualtuur.com
Panimator: https://krpano.com/plugins/userplugins/panimator/#top
ToolBox: https://bit.ly/3TTnd6U
Measure in 360 photos : https://pame.virtualtuur.com
Moving Hotspots V2: https://krpano.com/plugins/userplugins/movinghotspots/#top
Donations
https://bit.ly/3NnpynC

San7

Profi

Beiträge: 626

Beruf: coding in krpano

  • Nachricht senden

186

Donnerstag, 23. März 2023, 13:03

Zitat von »Tuur«

Zitat

I ususally use San7 approach for looping through hotspts, but Tuur, your code looks so much clearner!


yes but since the beginning of times doing a tween or so like that on a hotspot doesn't work in a for loop.
My code is just the same but the new syntax is used.
The callwith 'trick' worked already since it was available.

We used to do, because of this, for example:

Quellcode

 
1
2
3
4
5
6
7
8
9

for(set(i,0),i LT hotspot.count, inc(i),
		if(hotspot[get(i)].tag == 'labrador',
			Helper(get(hotspot[get(i)].name));
		);
);		
		
<action name="Helper">
		tween(hotspot[%1].volume, 9);
</action>


Tuur *thumbsup*

Tuur, thanks! I completely forgot that twin does not work in a cycle, my fault. *wacko*
Yes, "tween" needs to be isolated
https://novosibpano.ru/Plugins/


PanoramicWEB

Fortgeschrittener

Beiträge: 192

Wohnort: Turkey

Beruf: 360 Software and Hardware Developing

  • Nachricht senden

187

Donnerstag, 23. März 2023, 13:25

Hi Klaus,
Is there a plan for GLTF file as a hotspot? (not threejs layer i mean) Thank you.
PanoramicWEB Solutions

http://www.panoramicweb.net - info@panoramicweb.net

ctt360

Anfänger

Beiträge: 8

  • Nachricht senden

188

Donnerstag, 23. März 2023, 16:28

Layer text not reliably updated when the layer is invisible

Hi Klaus,

I noticed, that the text of invisible layers is not reliably updated, even after they switch to being visible. Please see this test case:
https://36o.de/test/krpano1.21-text-update/

After loading the tour, move the panorama at least a little bit, then press the character "p" on your keyboard. This will show the current numbers for hlookat, vlookat and fov in the bottom right corner of the tour. However, most of the time the number for ath (hlookat) will not be displayed. Sometimes, two or all three numbers are not displayed. When you start moving the panorama again, the numbers are usually displayed after a few seconds.
You can see the behavior in action in this video: https://36o.de/test/krpano1.21-text-update/video.mp4

If you can't immediately reproduce this, reload the tour and try it again. It doesn't seem to happen 100% of the time, but it does happen often for me in Chromium (111.0.5563.64) and Firefox (111.0.1) on Linux.

This is the complete code to reproduce the issue:

Quellcode

 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31

<action name="skin_keydown_event">
	if(
		keycode === 80,
		set(layer[text-pos].visible, true);
		pos_update();
	);
</action>

<events name="pos_update" keep="true" onviewchange="pos_update();" />

<action name="pos_update" scope="localonly">
	set(global.layer[text-ath].text, calc(roundval(global.view.hlookat, 2)));
	set(global.layer[text-atv].text, calc(roundval(global.view.vlookat, 2)));
	set(global.layer[text-fov].text, calc(roundval(global.view.fov, 2)));
</action>

<style name="text-position-bold" type="text" keep="true" align="rightbottom" padding="7" bgcolor="0xffffff"
	   css="color: #003064; font-family: Arial, sans-serif; font-size: 16px; font-weight: bold;" />

<style name="text-position" type="text" keep="true" align="rightbottom" padding="7" bgcolor="0xffffff"
	   css="color: #003064; font-family: Arial, sans-serif; font-size: 16px;" />

<layer name="text-pos" type="container" keep="true" align="rightbottom" x="30" y="160" visible="false">
	<layer name="text-ath" style="text-position-bold" x="48" y="80" text="0" />
	<layer name="text-atv" style="text-position-bold" x="48" y="40" text="0" />
	<layer name="text-fov" style="text-position-bold" x="48" y="0" text="0" />

	<layer name="text-ath-label" style="text-position" x="0" y="80" text="ATH" />
	<layer name="text-atv-label" style="text-position" x="0" y="40" text="ATV" />
	<layer name="text-fov-label" style="text-position" x="0" y="0" text="FOV" />
</layer>


Kind regards,
Christian

kme

Fortgeschrittener

Beiträge: 310

Wohnort: Belgium

Beruf: Long time coder, product manager and 3D enthousiast

  • Nachricht senden

189

Donnerstag, 23. März 2023, 17:24

Just a quick "i can reproduce" the scenario, so not something local.
Plugins and more on my gumroad page

kme

Fortgeschrittener

Beiträge: 310

Wohnort: Belgium

Beruf: Long time coder, product manager and 3D enthousiast

  • Nachricht senden

190

Donnerstag, 23. März 2023, 18:02

Workaround:

Quellcode

 
1
2
3
4
5
6
7
8
9

<action name="pos_update" scope="localonly">

	if (get(global.layer[text-pos].visible) == "true", 
		set(global.layer[text-ath].text, calc(roundval(global.view.hlookat, 2)));
		set(global.layer[text-atv].text, calc(roundval(global.view.vlookat, 2)));
		set(global.layer[text-fov].text, calc(roundval(global.view.fov, 2)));
	);

</action>


I have the feeling that doing too many things in the onviewchange() event is not optimal.
(Escpecially in the beginning when not everything is initialized yet)
Plugins and more on my gumroad page

San7

Profi

Beiträge: 626

Beruf: coding in krpano

  • Nachricht senden

191

Donnerstag, 23. März 2023, 18:16

Zitat von »ctt360«


I noticed, that the text of invisible layers is not reliably updated, even after they switch to being visible. Please see this test case:
https://36o.de/test/krpano1.21-text-update/

After loading the tour, move the panorama at least a little bit, then press the character "p" on your keyboard. This will show the current numbers for hlookat, vlookat and fov in the bottom right corner of the tour. However, most of the time the number for ath (hlookat) will not be displayed. Sometimes, two or all three numbers are not displayed. When you start moving the panorama again, the numbers are usually displayed after a few seconds.
Hi, most likely when "visible" is disabled, the layer is ignored. Manage "alpha" instead of "visible"

set(layer[text-pos].alpha, 1);
<layer name="text-pos" ... visible="true" alpha="0"
https://novosibpano.ru/Plugins/


ctt360

Anfänger

Beiträge: 8

  • Nachricht senden

192

Donnerstag, 23. März 2023, 21:54

Zitat von »kme«

Workaround:

Quellcode

 
1
2
3
4
5
6
7
8
9

<action name="pos_update" scope="localonly">

	if (get(global.layer[text-pos].visible) == "true", 
		set(global.layer[text-ath].text, calc(roundval(global.view.hlookat, 2)));
		set(global.layer[text-atv].text, calc(roundval(global.view.vlookat, 2)));
		set(global.layer[text-fov].text, calc(roundval(global.view.fov, 2)));
	);

</action>



Nice workaround, it does seem to work reliably this way.

----

Zitat von »San7«

Hi, most likely when "visible" is disabled, the layer is ignored. Manage "alpha" instead of "visible"

set(layer[text-pos].alpha, 1);
<layer name="text-pos" ... visible="true" alpha="0"


It does make sense that invisible layers are ignored. But I would expect changes to apply without a delay after setting the layer to visible.

Your solution does seem to work, but you'd need to also update attributes like "capture", "handcursor" etc. on the container and/or its child elements.

----

The code example might not be the best solution, but it's a snippet of legacy code in our app that worked as expected in older versions. I can easily refactor our own code, but this would not be possible with encrypted third party plugins.

Thank you for your input!

Kind regards,
Christian

indexofrefraction

Profi

Beiträge: 1 362

  • Nachricht senden

193

Donnerstag, 23. März 2023, 22:15

Zitat von »kme«

I have the feeling that doing too many things in the onviewchange() event is not optimal.
(Escpecially in the beginning when not everything is initialized yet)

just FYI it is possible to make your code snippet much lighter ;-)
you dont need get() in conditions or trace/debug(),
also set(x,calc(1+2)); is the same as calc(x, 1+2);
and set(x,get(y)); is the same as copy(x,y);

Quellcode

 
1
2
3
4
5
6
7

<action name="pos_update" scope="local">
	if(layer[text-pos].visible, 
		roundval(layer[text-ath].text, view.hlookat, 2);
		roundval(layer[text-atv].text, view.vlookat, 2);
		roundval(layer[text-fov].text, view.fov, 2);
	);
</action>
zFilter plugin -- zFlare plugin -- zSnapshot plugin

tomozoh932

Anfänger

Beiträge: 24

Wohnort: Japan

  • Nachricht senden

194

Freitag, 24. März 2023, 00:53

I have a question about the display of obj.

Is the error often on smart phones due to the size of the obj, etc?


When an error is returned on a smart phone, is it because it is a preview version that it shows as a demo version?

---------------------------------------------------------------
FATAL ERROR:
A Browser with WebGL support is required!
---------------------------------------------------------------
krpano
demo version




I am enjoying my first experience.
Thank you very much.

worinima2128

Anfänger

Beiträge: 8

Wohnort: Seoul

  • Nachricht senden

195

Freitag, 24. März 2023, 04:02

set3dtransition Two closely located hotspots are unable to function properly.

Hi Klaus,
Is it a bug if two hotspots in adjacent scenes, when placed too closely, do not work ideally or even poorly, resulting in vertical switching effect rather than horizontal effect? set3dtransition Is it a parameter setting issue?

indexofrefraction

Profi

Beiträge: 1 362

  • Nachricht senden

196

Freitag, 24. März 2023, 12:39

Zitat von »tomozoh932«

A Browser with WebGL support is required!

this should only happen on old or very cheap mobiles *squint*
zFilter plugin -- zFlare plugin -- zSnapshot plugin

klaus.krpano

Administrator

  • »klaus.krpano« ist der Autor dieses Themas

Beiträge: 13 499

  • Nachricht senden

197

Freitag, 24. März 2023, 14:53

Zitat von »ctt360«

I noticed, that the text of invisible layers is not reliably updated, even after they switch to being visible. Please see this test case:
https://36o.de/test/krpano1.21-text-update/

Zitat von »ctt360«

I would expect changes to apply without a delay after setting the layer to visible.
Thanks for the example!
Your expectation is right, this is indeed a bug.
It's fixed now for the next release (soon).


Zitat von »tomozoh932«

I have a question about the display of obj.
Is the error often on smart phones due to the size of the obj, etc?
When an error is returned on a smart phone, is it because it is a preview version that it shows as a demo version?
Sorry, but I don't understand what you mean...


Zitat von »worinima2128«

Is it a bug if two hotspots in adjacent scenes, when placed too closely, do not work ideally or even poorly, resulting in vertical switching effect rather than horizontal effect? set3dtransition Is it a parameter setting issue?
That's not directly a bug, that's the behavior defined the vtourskin.xml for 3d-transitions (see the skin_scene3dtransition action).

When the vertical viewing angle towards the hotspot is very 'upright/steep', then the action assumes that the hotspot is on another 'level' and makes a 3D-move into that direction.

To avoid this, change this line:

Quellcode

 
1

if(v GT -50 AND v LT +50 AND caller.depth GT 120, set(v,0));
to this:

Quellcode

 
1

set(v,0);


Best regards,
Klaus

tomozoh932

Anfänger

Beiträge: 24

Wohnort: Japan

  • Nachricht senden

198

Freitag, 24. März 2023, 16:01

Zitat von »indexofrefraction«

Zitat von »tomozoh932«

A Browser with WebGL support is required!

this should only happen on old or very cheap mobiles *squint*

Thank you very much.

It may be a rare bug in krpano.
We have tested it on PIXCEL 4a, 7, iPhoneSE and other smartphones.

klaus.krpano

Administrator

  • »klaus.krpano« ist der Autor dieses Themas

Beiträge: 13 499

  • Nachricht senden

199

Freitag, 24. März 2023, 16:14

Hi, that error would only appear when the browser doesn't offer WebGL support (for some reason).

tomozoh932

Anfänger

Beiträge: 24

Wohnort: Japan

  • Nachricht senden

200

Freitag, 24. März 2023, 17:30

Zitat von »klaus.krpano«

Hi, that error would only appear when the browser doesn't offer WebGL support (for some reason).
klaus.krpano-san


Thank you very much.


It was displayed while prototyping a tour of obj files.

Version of krpano,krpano-1.21_pre_2023-03-21.



1.Does the WebGL error show demo?
We have registered our license.

2.It may be extremely rare, but the same error may occur in a tour of obj files.

After the error message, another prototype tour of the same krpano version worked.


Thank you all.

Once discarded, I'm enjoying it in other prototypes *smile*

Ähnliche Themen