How to optimize this code? [SOLVED]

Fernando · August 9, 2017 at 12:35 AM

This is the large way, It is works ok, but isn't ideal code...almost the same 80 times!!!

if(videotime GE (tiempos[ruta1].t0)
AND videotime LE (tiempos[ruta1].t1),
aproxima(videotime,tiempos[ruta1].t0,tiempos[ruta1].t1,0,1);
);

if(videotime GE (tiempos[ruta1].t1)
AND videotime LE (tiempos[ruta1].t2),
aproxima(videotime,tiempos[ruta1].t1,tiempos[ruta1].t2,1,2);
);

if(videotime GE (tiempos[ruta1].t2)
AND videotime LE (tiempos[ruta1].t3),
aproxima(videotime,tiempos[ruta1].t2,tiempos[ruta1].t3,2,3);
);

--------
I want anything as:

for (set i,0), i LT 84, inc(i)

if(videotime GE (tiempos[ruta1].t(i) )... etc

---------
Note:
My original array is:
<tiempos name="ruta1"
t0="0" t1="10" t2="18" t3="26" t4="35" t5="44" t6="53" t7="63"...t84="793"
/>
--------

Any idea, thanks!!

spacerywirtualne · August 9, 2017 at 1:28 AM

Hi

Try this:

Code

<action name="for84" >  
 for(set(i,0),i LT 84,inc(i),    
  copy(t1, i);    
  calc(t2, t1+1);    
  if(videotime GE calc('tiempos[ruta1].t'+t1) AND videotime LE calc('tiempos[ruta1].t'+t2),      
   aproxima(videotime,calc('tiempos[ruta1].t'+t1),calc('tiempos[ruta1].t'+t2),get(t1),get(t2));    
  );  
 );
</action>

Best regards
Piotr

Fernando · August 10, 2017 at 3:12 AM

Thanks Piotr for your help, very interesting, CALC is new, from 1.19 and is the good way. thanks for teach me this great function, and your example.

But there is a problem in the code:

if check by trace... calc('tiempos[ruta1].t'+t1) ... It is return a correct result from array, but fails in the comparison function GE ... LE as the result was a string, no a number.

Any idea?

Thanks very much,
Greets,
Fdo.

spacerywirtualne · August 10, 2017 at 12:05 PM

Hi

I do not know your entire code so I can only guess...

Maybe use a GET function in this code

if(videotime GE calc('get(tiempos[ruta1].t'+t1+')') AND videotime LE calc('get(tiempos[ruta1].t'+t2+')'),
aproxima(videotime,calc('get(tiempos[ruta1].t'+t1+')'),calc('get(tiempos[ruta1].t'+t2+')'),get(t1),get(t2));
);

Best regards
Piotr

Fernando · August 10, 2017 at 4:38 PM

Thanks Piotr, but... why to use GET?: The variable get the correct value, the problem is in the comparison. See the example:

Code

<krpano
debugmode="true" onstart="arranque();">


<preview type="grid(cube,128,128,512,0xCCCCCC,0xF6F6F6,0x999999);" />


<events onkeydown="keydown()"/>


<layer name="help" 
type="text"
css="text-align:left; font-size:24px;"
align="centertop"
html="
Press key 1: To Play the count[br]
Press key 2: To Pause the count[br]
Press key 3: To Restart the count[br]
Press key 4: To Compare the current count with:[br]
0 , 2 , 3 , 7 , 9 and 10 
"
/>


<action name="arranque">
set(videotime,0); 
</action>


<action name="keydown">


<!-- key 1: -->
if(keycode == 49, 
showlog();
trace('PLAY the count...');
incrementa_auto(); 
);


<!-- key 2: -->
if(keycode == 50,
trace('PAUSE the count...');
parar();
);


<!-- key 3: -->
if(keycode == 51,
trace('RESTART the count...');
set(videotime,0);
incrementa_auto();
);


<!-- key 4: -->
if(keycode == 52,
trace('CHECKING the array...');
for5();
);


</action>


<tiempos
name="ruta1"
t0="0" t1="2" t2="3" t3="7" t4="9" t5="10" 
/>


<action name="incrementa">
inc(videotime);
trace(get(videotime));
</action>


<action name="incrementa_auto">
delayedcall(conteo,1.0, incrementa();incrementa_auto(); );
</action>


<action name="parar">
stopdelayedcall(conteo);
</action>


<action name="for5" >  
 for(set(i,0),i LT 5,inc(i),    
  copy(t1, i);    
  calc(t2, t1+1);    
  if(videotime GE calc('tiempos[ruta1].t'+t1) AND videotime LE calc('tiempos[ruta1].t'+t2),
  
trace('The Count:',videotime,' is greater or equal than ',calc('tiempos[ruta1].t'+t1),' and lower or equal than ',calc('tiempos[ruta1].t'+t2)); 
parar();,


trace('The Count:',videotime,' is NOT greater or equal than ',calc('tiempos[ruta1].t'+t1),' and is NOT lower or equal than ',calc('tiempos[ruta1].t'+t2)); 
parar();
    
  );  
 );
</action>  


</krpano>

Display More

Greets,
Fdo

spacerywirtualne · August 10, 2017 at 5:36 PM

You must separate the code like this:

Code

<action name="for5">
 for(set(i,0),i LT 5,inc(i), 
   copy(t1, i); 
   calc(t2, t1+1);
   check_result(get(videotime),calc('tiempos[ruta1].t'+t1),calc('tiempos[ruta1].t'+t2));
 );
</action>


<action name="check_result">
 if((%1 GE %2) AND (%1 LE %3),
   trace('BETWEEN: The Count: %1 is greater or equal than ',get(%2),' AND lower or equal than ',get(%3)); 
   parar();
 ,
   trace('BEYOND: The Count: %1 is NOT greater or equal than ',get(%2),' AND is NOT lower or equal than ',get(%3)); 
   parar();
 ); 
</action>

Display More

Let me know if this work

Best regards
Piotr

Fernando · August 10, 2017 at 7:00 PM

It works!!!!

The code is great, the ¨BEYOND¨ part, complete the example.

Thanks very much Piotr for your fast and precise help,

Greets,

Fdo

spacerywirtualne · August 10, 2017 at 7:51 PM

Hi,

This was an interesting issue, interesting and worth solution.

Regards and good luck in coding

Piotr

How to optimize this code? [SOLVED]

Participate now!

Users Viewing This Thread