if(then-action) - cleaner code method?

MalcolmLoudon · July 26, 2012 at 5:45 PM

Hi Folks, just wondering whether there's a more concise/clean way of coding the following?

e.g.

Code

onclick="
		  if(plugin[graphic_1].visible == true,set(plugin[graphic_a].visible, true));
		  if(plugin[graphic_1].visible == true,set(plugin[graphic_b].visible, true));
		  if(plugin[graphic_1].visible == true,set(plugin[graphic_c].visible, true));
		  if(plugin[graphic_1].visible == true,set(plugin[graphic_d].visible, true));
		  if(plugin[graphic_1].visible == true,set(plugin[graphic_e].visible, true));
		  if(plugin[graphic_1].visible == true,set(plugin[graphic_f].visible, true));
		  
		  if(plugin[graphic_2].visible == true,set(plugin[graphic_g].visible, true));
		  if(plugin[graphic_2].visible == true,set(plugin[graphic_h].visible, true));
		  if(plugin[graphic_2].visible == true,set(plugin[graphic_i].visible, true));
		  if(plugin[graphic_2].visible == true,set(plugin[graphic_j].visible, true));
		  if(plugin[graphic_2].visible == true,set(plugin[graphic_k].visible, true));
		  if(plugin[graphic_2].visible == true,set(plugin[graphic_l].visible, true));"/>

Display More

Thanks as ever. My "onclick" code for one button is now 100s of lines long!

Malcolm

sachagriffin · July 26, 2012 at 7:42 PM

Set all those plugins to be the parent of the other or use the grouping code that can manipulate attributes based in tags

ahoeben · July 27, 2012 at 9:27 AM

The first optimisation should be this:

Code

onclick="
if(plugin[graphic_1].visible == true,
	set(plugin[graphic_a].visible, true);
	set(plugin[graphic_b].visible, true);
	set(plugin[graphic_c].visible, true);
	set(plugin[graphic_d].visible, true);
	set(plugin[graphic_e].visible, true);
	set(plugin[graphic_f].visible, true);
);
if(plugin[graphic_2].visible == true,
	set(plugin[graphic_g].visible, true);
	set(plugin[graphic_h].visible, true);
	set(plugin[graphic_i].visible, true);
	set(plugin[graphic_j].visible, true);
	set(plugin[graphic_k].visible, true);
	set(plugin[graphic_l].visible, true);
);"

Display More

Much easier on the eye, and better performance too.
But depending on what you want achieve, you could set the parent of graphic_a through graphic_f to be graphic_1. That way they hide automatically when graphic_1 hides.

MalcolmLoudon · July 27, 2012 at 11:29 AM

That's great guys, just what I was looking for. Many thanks!

if(then-action) - cleaner code method?

Participate now!

Users Viewing This Thread