iphone_fullscreen_swipe fails unless style is in div tag

  • Totally weird. Unless you set height and width to 100% in a style element inside the pano div tag (inline), iphone_fullscreen_swipe won't work. If you set these in a stylesheet instead, the div will size as expected but iphone_fullscreen_swipe doesn't work. I can't see anything in the javascript that would cause this so I suspect it has to do with the oniphonefullscreen event not firing.

    Also, I found that the viewport meta tag must include "viewport-fit=cover" although that makes a little more sense.

    Thoughts?

  • What is the actual problem?


    Mostly that this isn't documented anywhere that I could find.

    The normal practice is for CSS to be in stylesheets (internal or external) vs inline. It took me forever to figure out that in this case, it had to be inline. Being in a stylesheet didn't matter. I don't think that is intuitive so it would be useful for you to document it. Better still, IMHO, would be for it to not matter where height and width are set if that is possible.

    I feel it is good to document anything needed to make something work, including something like viewport-fit. That way, if something isn't working for someone they can more easily figure it out.

    BTW, your figuring out how to get around limitations like the lack of real fullscreen on the iphone is hugely appreciated.

  • Hi,

    The normal practice is for CSS to be in stylesheets (internal or external) vs inline. It took me forever to figure out that in this case, it had to be inline.

    Okay, I think I know now what you mean, currently there is only a simple check for element.style in this case, but for including also style sheets getComputedStyle would need to be used instead. Will change that in the next releases.


    I feel it is good to document anything needed to make something work, including something like viewport-fit. That way, if something isn't working for someone they can more easily figure it out.

    It's already my intention to document everything ;-).

    Best regards,
    Klaus

Participate now!

Don’t have an account yet? Register yourself now and be a part of our community!