progress.progress only work on scope=local?Loading Progress demo bug

arielei

since version1.2,it can't display progress' correct value.

if action not set scope="local",it will show like:
0%
17%

and then the layer (loadingpercent_text) will be hide

link:https://krpano.com/releases/1.20.…ress/index.html

xml:https://krpano.com/viewsource.htm…percenttext.xml

fix code:

Code

<krpano>


	<!-- loading percent events -->
	<events name="loadingpercent" keep="true"
	        onxmlcomplete="loadingpercent_startloading();"
	        />


	<!-- loading percent text -->
	<layer name="loadingpercent_text" keep="true"
	       type="text"
	       align="center"
	       y="10%"
	       background="false"
	       css="color:#FFFFFF; font-family:Arial; font-weight:bold; font-size:22px; font-style:italic;" textshadow="2"
	       html=""
	       />


	<!-- loading percent actions -->
	<action name="loadingpercent_startloading" scope="local">
		set(loadingpercent_isloading, true);
		set(layer[loadingpercent_text].visible, true);
		asyncloop(loadingpercent_isloading,
			trace(progress.progress);
			mul(pv, progress.progress, 100);
			roundval(pv,0);
			txtadd(layer[loadingpercent_text].html, 'Loading ', get(pv), '%');
			if(pv==100,delayedcall(0.25,set(loadingpercent_isloading, false);set(layer[loadingpercent_text].visible, false);););
		  );
	</action>


</krpano>

Alles anzeigen

code:

krpano example:

fix:

klaus.krpano

Hi,

sorry, but I don't understand that case...
For me the example as it is, is working correctly...

About scope=local - just adding that to the original example wouldn't work because both actions (loadingpercent_startloading and loadingpercent_stoploading) are using the same variables. Here optionally also a private local scope could be used to share the variables.

Best regards,
Klaus

arielei

Zitat von klaus.krpano

Hi,
sorry, but I don't understand that case...
For me the example as it is, is working correctly...
About scope=local - just adding that to the original example wouldn't work because both actions (loadingpercent_startloading and loadingpercent_stoploading) are using the same variables. Here optionally also a private local scope could be used to share the variables.
Best regards,
Klaus

1.20.9 original example:

Code

<action name="loadingpercent_startloading">
		showlog();
		set(loadingpercent_isloading, true);
		set(layer[loadingpercent_text].visible, true);


		asyncloop(loadingpercent_isloading,
			mul(pv, progress.progress, 100);
			roundval(pv,0);
			trace('percent_text:',pv);
			txtadd(layer[loadingpercent_text].html, 'Loading ', get(pv), '%');
		  );
	</action>

Alles anzeigen

result:

Code

INFO: krpano 1.20.9 (build 2020-11-19)
INFO: HTML5/Desktop - Chrome 88.0 - WebGL
INFO: percent_text:0 [145x]
INFO: percent_text:17
INFO: percent_text:33 [15x]

1.20.9 my code:

Code

<action name="loadingpercent_startloading" scope="local">
		showlog();
		set(loadingpercent_isloading, true);
		set(layer[loadingpercent_text].visible, true);
		asyncloop(loadingpercent_isloading,
			mul(pv, progress.progress, 100);
			roundval(pv,0);
			trace('percent_text:',pv);
			txtadd(layer[loadingpercent_text].html, 'Loading ', get(pv), '%');
			if(pv==100,delayedcall(0.25,set(loadingpercent_isloading, false);set(layer[loadingpercent_text].visible, false);););
		  );
	</action>

Alles anzeigen

result:

Code

INFO: krpano 1.20.9 (build 2020-11-19)
INFO: HTML5/Desktop - Chrome 88.0 - WebGL
INFO: percent_text:0 [162x]
INFO: percent_text:17
INFO: percent_text:33 [87x]
INFO: percent_text:50 [30x]
INFO: percent_text:67 [76x]
INFO: percent_text:83 [48x]
INFO: percent_text:100 [16x]

1.19.10 original example result:

Code

INFO: krpano 1.19-pr10 (build 2017-05-10)
INFO: HTML5/Desktop - Chrome 88.0 - WebGL
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:0
INFO: percent_text:17
INFO: percent_text:17
INFO: percent_text:17
INFO: percent_text:17
INFO: percent_text:17
INFO: percent_text:17
INFO: percent_text:17
INFO: percent_text:17
INFO: percent_text:17
INFO: percent_text:17
INFO: percent_text:17
INFO: percent_text:17
INFO: percent_text:17
INFO: percent_text:17
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:33
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:50
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:67
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:83
INFO: percent_text:100
INFO: percent_text:100
INFO: percent_text:100
INFO: percent_text:100
INFO: percent_text:100
INFO: percent_text:100
INFO: percent_text:100
INFO: percent_text:100
INFO: percent_text:100
INFO: percent_text:100
INFO: percent_text:100
INFO: percent_text:100
INFO: percent_text:100
INFO: percent_text:100
INFO: percent_text:100
INFO: percent_text:100

Alles anzeigen

Jetzt mitmachen!